On 04/11/2018 06:23, David Rowley wrote:
> Thanks for looking at this.
> 
> On 2 November 2018 at 20:30, Peter Eisentraut
> <peter.eisentr...@2ndquadrant.com> wrote:
>>      <para>
>> -     Execution-time partition pruning currently occurs for the
>> +     Execution-time partition pruning currently only occurs for the
>>       <literal>Append</literal> and <literal>MergeAppend</literal> node
>> types.
>> +     It is not yet implemented for the <literal>ModifyTable</literal> node
>> +     type.
>>      </para>
>>
>> Isn't this implied by the preceding paragraph
>>
>>     Currently, pruning of partitions during the planning of an UPDATE or
>> DELETE command is implemented using the constraint exclusion method
> 
> That paragraph is talking about plan-time partition pruning. The
> paragraph the patch changes is mentioning execution-time partition
> pruning.  In PG11 we have plan-time partition pruning for Append and
> MergeAppend. UPDATE/DELETE does pruning, but it uses the constraint
> exclusion code which does not work for HASH partitioned tables.  In
> PG11 we only have run-time partition pruning for Append.   MergeAppend
> support was only added in 5220bb7533 (PG12).

I see now.  The actual documentation change was separate in db72302b0a8.

Committed your change.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply via email to