Hi,

On 11/12/18 6:17 PM, David Rowley wrote:
On 9 November 2018 at 19:18, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote:
I have a comment regarding how you chose to make
PartitionTupleRouting private.

Using the v14_to_v15 diff, I could quickly see that there are many diffs
changing PartitionTupleRouting to struct PartitionTupleRouting, but they
would be unnecessary if you had added the following in execPartition.h, as
my upthread had done.

-/* See execPartition.c for the definition. */
+/* See execPartition.c for the definitions. */
  typedef struct PartitionDispatchData *PartitionDispatch;
+typedef struct PartitionTupleRouting PartitionTupleRouting;

Okay, done that way. v16 attached.


Still passes check-world.

Best regards,
 Jesper


Reply via email to