Hi, Right now there's no easy way to use the compiler to ensure that all places that need to deal with all kinds of relkinds check a new relkind. I think we should make that easier by moving RELKIND_* to an enum, with the existing letters as the value.
Obviously we cannot really do that for FormData_pg_class.relkind, but switch() statements can easily cast that to RelationRelkind (or whatever we name it). Does anybody see a reason not to do so? Greetings, Andres Freund