Hi, On Thu, Dec 20, 2018 at 04:19:11PM +0100, Michael Banck wrote: > Yeah, new rebased version attached.
By the way, one thing that this patch also fixes is checksum verification on basebackups (as pointed out the other day by my colleague Bernd Helmele): postgres@kohn:~$ initdb -k data postgres@kohn:~$ pg_ctl -D data -l logfile start waiting for server to start.... done server started postgres@kohn:~$ pg_verify_checksums -D data pg_verify_checksums: cluster must be shut down to verify checksums postgres@kohn:~$ pg_basebackup -h /tmp -D backup1 postgres@kohn:~$ pg_verify_checksums -D backup1 pg_verify_checksums: cluster must be shut down to verify checksums postgres@kohn:~$ pg_checksums -c -D backup1 Checksum scan completed Files scanned: 1094 Blocks scanned: 2867 Bad checksums: 0 Data checksum version: 1 Where pg_checksums has the online verification patch applied. As I don't think many people will take down their production servers in order to verify checksums, verifying them on basebackups looks like a useful use-case that is currently broken with pg_verify_checksums. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz