Michael Paquier <mich...@paquier.xyz> writes: > On Thu, Dec 20, 2018 at 12:02:52AM +0000, Dagfinn Ilmari Mannsåker wrote: >> Point, fixed in the attached v4. OTOH, as I mentioned in my other >> email, that runs into the problem that it won't complete the actions >> after e.g. "CREATE TEMP TABLE FOO () WITH () ON COMMIT". > > I am fine to do that later on if that's adapted, one complication being > that the completion is dependent on the order of the clauses for CREATE > TABLE as we need something compatible with CREATE TABLE commands bundled > with CREATE SCHEMA calls so only tail checks can be done.
Yeah, because of that we can't do the obvious HeadMatches("CREATE", "TABLE") && (TailMatches(...) || TailMatches(...) || ...). I believe this would require extending the match syntax with regex-like grouping, alternation and repetition operators, which I'm not volunteering to do. > So committed your last version after some comment tweaks and reordering > the entries in alphabetical order. Thanks! - ilmari -- "The surreality of the universe tends towards a maximum" -- Skud's Law "Never formulate a law or axiom that you're not prepared to live with the consequences of." -- Skud's Meta-Law