On Tue, Jan 08, 2019 at 01:13:11PM +0900, Amit Langote wrote: > Yeah, I think so too. I also noticed that the patch uses > ERRCODE_WRONG_OBJECT_TYPE as the error code, whereas we may want to use > ERRCODE_FEATURE_NOT_SUPPORTED. Thoughts on that?
ERRCODE_WRONG_OBJECT_TYPE is the right call I think as the feature is actually supported, just not for all the object types. > Attached updated patch, which changes the detail message text as you > suggest and updates the error code. Another suggestion I would have is also to change the third message of CheckSubscriptionRelkind() so as its style maps the two others you are adding, as what's on HEAD is not a model of its kind with its formulation using a full sentence. -- Michael
signature.asc
Description: PGP signature
