On Fri, Jan 11, 2019 at 12:33 PM Andrew Gierth <and...@tao11.riddles.org.uk> wrote: > >>>>> "Robert" == Robert Haas <robertmh...@gmail.com> writes: > Robert> I don't have an opinion on the code that is part of this patch > > At this point, frankly, I'm less interested in opinions on the code > itself (which can be addressed later if need be) than on answers to (or > discussion of) the questions asked upthread.
Unfortunately, I can't help you very much there. My knowledge is insufficient to give intelligent answers to those questions, and I don't think giving you unintelligent answers is a good idea. About as much as I can say is that if you commit this patch, and as a result, a dump-and-restore from v11 to v12 causes a change in the bits on disk that would not have occurred without this patch, that's very bad. What ramifications there will be if the output changes in ways that don't affect the bits that get written to the platter -- I don't know. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
