On Fri, 18 Jan 2019 at 19:29, Surafel Temesgen <surafel3...@gmail.com> wrote: > this happen because i don't disallow the usage of --inserts and > --rows-per-insert > option together.it should be error out in those case.i correct it in attached > patch
I don't think it should be an error. It's not like the two options conflict. I imagined that you'd need to specify you want --inserts and optionally could control how many rows per statement that would be put in those commands. I'd be surprised to be confronted with an error for asking for that. It might be worth doing the same as what we do if --column-inserts is specified without --inserts. In this case we just do: /* --column-inserts implies --inserts */ if (dopt.column_inserts) dopt.dump_inserts = 1; If you do it that way you'll not need to modify the code much from how I wrote it. We can likely debate if we want --rows-per-insert to imply --inserts once there's a working patch. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
