Let me remind the thread. If no more comments, objections, or better ideas, please commit this fix.
Thanks, 2019年1月17日(木) 18:29 Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp>: > > Hello, sorry for the absence. > > At Fri, 11 Jan 2019 11:36:43 -0500, Robert Haas <robertmh...@gmail.com> wrote > in <CA+TgmoYyxBgkfN_APBdxdutFMukb=p-eggny-nbaurcl7mg...@mail.gmail.com> > > On Thu, Jan 10, 2019 at 9:10 PM Kohei KaiGai <kai...@heterodb.com> wrote: > > > 2019年1月11日(金) 5:52 Robert Haas <robertmh...@gmail.com>: > > > > On Wed, Jan 9, 2019 at 12:44 AM Kohei KaiGai <kai...@heterodb.com> > > > > wrote: > > > > > So, is it sufficient if set_rel_pathlist_hook is just relocated in > > > > > front of the generate_gather_paths? > > > > > If we have no use case for the second hook, here is little necessity > > > > > to have the post_rel_pathlist_hook() here. > > > > > (At least, PG-Strom will use the first hook only.) > > > > > > > > +1. That seems like the best way to be consistent with the principle > > > > that we need to have all the partial paths before generating any > > > > Gather paths. > > > > > > > Patch was updated, just for relocation of the set_rel_pathlist_hook. > > > Please check it. > > > > Seems reasonable to me. > > Also seems reasonable to me. The extension can call > generate_gather_paths redundantly as is but it almost doesn't > harm, so it is acceptable even in a minor release. > > regards. > > -- > Kyotaro Horiguchi > NTT Open Source Software Center > -- HeteroDB, Inc / The PG-Strom Project KaiGai Kohei <kai...@heterodb.com>