Re: Andres Freund 2019-01-30 <20190130015127.hciz36lpmu7pr...@alap3.anarazel.de> > I'm confused - that doesn't allow to inject flags to all in-core built > files? So how does that fix your problem fully? Say > e.g. llvmjit_inline.cpp won't get the flag, and thus not be > reproducible?
The original itch being scratched here is extensions written in C++, which need -ffile-prefix-map (or -fdebug-prefix-map) injected into CXXFLAGS on top of the flags encoded in pgxs.mk. I originally picked COPT because that works for injecting flags into pgxs.mk as well, but PG_*FLAGS is better. For the server build itself, it shouldn't be necessary to inject flags because they are passed directly to ./configure. Admittedly I haven't looked at reproducibility of PG11 yet as clang is still missing the prefix-map feature, but https://reviews.llvm.org/D49466 is making good progress. Do we still want some CXXOPT flag for the server build? I can write a patch, but someone else would need to do the bikeshedding how to name it, and which of the existing knobs would set CXXFLAGS along. I don't think I need that feature. Christoph -- Senior Berater, Tel.: +49 2166 9901 187 credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz