Hi, On 2018-12-14 16:55:42 +0900, Michael Paquier wrote: > On Thu, Dec 13, 2018 at 01:51:48PM +0300, Sergei Kornilov wrote: > > Depends on this discussion: > > https://www.postgresql.org/message-id/20181212053042.gk17...@paquier.xyz > > If walreceiver will use GUC conninfo for startup - then yes, we can > > remove such static variables. If walreceiver will still use conninfo > > from WalRcv - we have race condition between RequestXLogStreaming from > > startup, config reload, and walreceiver start. In this case I need > > save conninfo from WalRcv and compare new GUC value with them. > > I would recommend waiting for the conclusion of other thread before > moving on with this one. There are arguments for letting the startup > process deciding which connection string the WAL receiver should use as > well as letting the WAL receiver use directly the connection string from > the GUC.
I suggest continuing the development of the patch without relying on that refactoring. Greetings, Andres Freund
