On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote: > In that case I propose that we avoid the whole issue by removing > -Wdeclaration-after-statement entirely.
Some folks who skip $SUBJECT will be interested in your proposal. If you wish to pursue that proposal, please start a new thread. On Sun, Feb 03, 2019 at 07:14:13AM +0000, Andrew Gierth wrote: > >>>>> "Noah" == Noah Misch <n...@leadboat.com> writes: > > Noah> - # -Wdeclaration-after-statement isn't applicable for C++ > Noah> + # -Wdeclaration-after-statement isn't applicable for C++. Specific > C files > Noah> + # disable it, so AC_SUBST the negative form. > Noah> + PERMIT_DECLARATION_AFTER_STATEMENT= > Noah> + if test x"$save_CFLAGS" != "$CFLAGS"; then > > Missing "x" here? > > + if test x"$save_CFLAGS" != x"$CFLAGS"; then I'll incorporate your fix. Thanks.