On Tue, Feb 19, 2019 at 4:07 PM David Rowley
<david.row...@2ndquadrant.com> wrote:
> I'd say that here we should only discuss what this patch is doing, ...
On that note, I spent some more time looking at what the patch is doing today.
/*
* We locked all the partitions in ExecSetupPartitionTupleRouting
* including the leaf partitions.
*/
- partrel = table_open(dispatch->partdesc->oids[partidx], NoLock);
+ partrel = table_open(dispatch->partdesc->oids[partidx], RowExclusiveLock);
It seems to me that the reason for this change is precisely that the
comment is now false, and therefore the comment needs to be updated.
Does that sound right?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
