On Mon, Feb 25, 2019 at 3:56 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Feb 25, 2019 at 02:38:05AM +0000, Tsunakawa, Takayuki wrote: > > From: Julien Rouhaud [mailto:rjuju...@gmail.com] > >> One last thing, I think we should at least add one regression test for > >> this setting. The one you provided previously seems perfectly suited. > > > > Thanks, added. > > +SELECT pg_relation_size('reloptions_test'); > + pg_relation_size > +------------------ > + 8192 > +(1 row) > This makes the test page-size sensitive. While we don't ensure that > tests can be run with different page sizes, we should make a maximum > effort to keep the tests compatible if that's easy enough.
Also, I think that this test may fail in case where concurrent transactions are running. So maybe should not run it in parallel to other tests. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
