On Tue, Mar 05, 2019 at 11:04:17PM +0900, Amit Langote wrote: > Maybe we should error out as follows in > transformPartitionRangeBounds(), although that means we'll get > different error message than when using list partitioning syntax:
Hm. I don't think that this is a good idea as you could lose some information for the expression transformation handling, and the error handling becomes inconsistent depending on the partition bound strategy. It seems to me that if we cannot extract any special value from the ColumnRef expression generated, then we ought to let transformPartitionBoundValue() and particularly transformExprRecurse() do the analysis work and complain if needed: =# CREATE TABLE rp_part PARTITION OF range_parted FOR VALUES FROM (unknown.unknown) TO (1); ERROR: 42P01: missing FROM-clause entry for table "unknown" LINE 1: ...p_part PARTITION OF range_parted FOR VALUES FROM (unknown.un... =# CREATE TABLE rp_part PARTITION OF range_parted FOR VALUES FROM (a.a.a.a.a.a.a.a.a.a.a.a) TO (1); ERROR: 42601: improper qualified name (too many dotted names): a.a.a.a.a.a.a.a.a.a.a.a LINE 1: ...p_part PARTITION OF range_parted FOR VALUES FROM (a.a.a.a.a.... What about something like the attached instead? Minus the test cases which should go to create_table.sql of course. -- Michael
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index a37d1f18be..ee129ba18f 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -3750,8 +3750,16 @@ transformPartitionRangeBounds(ParseState *pstate, List *blist,
IsA(linitial(cref->fields), String))
cname = strVal(linitial(cref->fields));
- Assert(cname != NULL);
- if (strcmp("minvalue", cname) == 0)
+ if (cname == NULL)
+ {
+ /*
+ * No field names have been found, meaning that there
+ * is not much to do with special value handling. Instead
+ * let the expression transformation handle any errors and
+ * limitations.
+ */
+ }
+ else if (strcmp("minvalue", cname) == 0)
{
prd = makeNode(PartitionRangeDatum);
prd->kind = PARTITION_RANGE_DATUM_MINVALUE;
signature.asc
Description: PGP signature
