Hi!
> 20 февр. 2019 г., в 17:06, Alexey Kondratov <a.kondra...@postgrespro.ru>
> написал(а):
>
>>
>> I will work out this one with postgres -C and come back till the next
>> commitfest. I found that something similar is already used in pg_ctl and
>> there is a mechanism for finding valid executables in exec.c. So it does not
>> seem to be a big deal at the first sight.
>>
>
> I have reworked the patch, please find new version attached. It is 3 times as
> smaller than the previous one and now touches pg_rewind's code only. Tests
> are also slightly refactored in order to remove duplicated code. Execution of
> postgres -C is used for restore_command retrieval (if -r is passed) as being
> suggested. Otherwise everything works as before.
>
> <v4-0001-pg_rewind-options-to-use-restore_command.patch>
The new patch is much smaller (less than 400 lines) and works as advertised.
There's a typo "retreive" there.
These lines look a little suspicious:
char postgres_exec_path[MAXPGPATH],
postgres_cmd[MAXPGPATH],
cmd_output[MAX_RESTORE_COMMAND];
Is it supposed to be any difference between MAXPGPATH and MAX_RESTORE_COMMAND?
Besides this, patch looks fine to me.
Best regards, Andrey Borodin.
