On Thu, Mar 14, 2019 at 12:37 PM John Naylor <john.nay...@2ndquadrant.com> wrote: > > On Thu, Mar 14, 2019 at 2:17 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > 1. Added an Assert in new_cluster_needs_fsm() that old cluster version > > should be >= 804 as that is where fsm support has been added. > > There is already an explicit check for 804 in the caller, >
Yeah, I know that, but I have added it to prevent this function being used elsewhere. OTOH, maybe you are right that as per current code it is superfluous, so we shouldn't add this assert. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com