Bonjour Michaël,
Here are my notes about the fixes:
Thanks for the fixes.
- pg_resetwal got broken because the path to the control file was incorrect. Running tests of pg_upgrade or the TAP tests of pg_resetwal showed the failure.
Hmmm… I thought I had done that with "make check-world":-(
- pg_rewind was issuing a flush of the control file even if --no-sync was used.
Indeed, I missed this one.
- Nit: incorrect header order in controldata_utils.c. I have kept the backend-only includes grouped though.
I'll pay attention to that the next time. Thanks for the push. -- Fabien.
