On Fri, Mar 22, 2019 at 11:05 AM Alexander Korotkov <aekorot...@gmail.com> wrote: > On Fri, Mar 22, 2019 at 12:06 AM Alvaro Herrera > <alvhe...@2ndquadrant.com> wrote: > > On 2019-Mar-21, Alexander Korotkov wrote: > > > > > However, I think this still can be backpatched correctly. We can > > > determine whether xlog record data contains deleteXid by its size. > > > See the attached patch. I haven't test this yet. I'm going to test > > > it. If OK, then push. > > > > Wow, this is so magical that I think it merits a long comment explaining > > what is going on. > > Yeah, have to fo magic to fix such weird things :) > Please, find next revision of patch attached. It uses static > assertion to check that data structure size has changed. Also, > assertion checks that record data length match on of structures > length.
I'm going to backpatch this on no objections. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company