On Wed, Mar 27, 2019 at 12:21 AM legrand legrand <legrand_legr...@hotmail.com> wrote: > > here is a new version: > > - "track_planning" GUC added > to permit to keep previous behavior unchanged
good > - trailing whitespaces and comments wider than 80 characters > not fixed why? In case it's not clear, I'm talking about the .c file, not the regression tests. > - "Assert(planning_time > 0 && total_time > 0);" > moved at the beginning of pgss_store Have you tried to actually compile postgres and pg_stat_statements with --enable-cassert? This test can *never* be true, since you either provide the planning time or the execution time or neither. As I said in my previous mail, adding a parameter to say which counter you're updating, instead of adding another counter that's mutually exclusive with the other would make everything clearer.
