On Tue, Mar 26, 2019 at 3:24 PM Jerry Jelinek <jerry.jeli...@joyent.com> wrote: > The latest patch is rebased, builds clean, and passes some basic testing. > Please let me know if there is anything else I could do on this.
I agree with Thomas Munro's earlier critique of the documentation. The documentation of the new parameters makes an assumption, completely unsupported in my view, about when those parameters should be set, yet at the same time gives almost no information about what they actually do. I don't like that. The patch needs a visit from pgindent, too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company