The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation: not tested
I have read disable-vacuum-truncation_v6.patch. I like it the way it is. Word "truncation" for me means "remove everything from the table" (as in TRUNCATE) and I don't want VACUUM to do that :), shrink feels appropriate. TRIM has a connotation from SSD drives, where you can discard blocks in the middle of your data and let the underlying infrastructure handle space allocation on it. Please keep it for the good times Postgres can punch a hole in the middle of relation and let filesystem handle that space. The new status of this patch is: Ready for Committer