On Fri, Apr 12, 2019 at 07:27:44PM +0900, Masahiko Sawada wrote: > As far as I know there are three places where call > pgstat_report_wait_end before ereport(ERROR): two in twophase.c > andanother in copydir.c(at L199). Since we eventually call > pgstat_report_wait_end() in AbortTransaction(). I think that we don't > need to call pgstat_report_wait_end() if we're going to raise an error > just after that. Is that right?
RecreateTwoPhaseFile() gets called in the checkpointer or the startup process which do not have a transaction context so the wait event would not get cleaned up, and we should call pgstat_report_wait_end() in the third elog(ERROR), no? It looks that 249cf070 has been rather inconsistent in its way of handling things. -- Michael
signature.asc
Description: PGP signature
