Andres Freund <and...@anarazel.de> writes: > On 2019-04-17 18:57:00 -0400, Tom Lane wrote: >> What on God's green earth are these functions doing in >> src/include/catalog/index.h?
> I'm happy to move them elsewhere, but I'm not sure there's really a good > location. I guess we could move them to itemptr.h - but they're not > really something particularly generally usable. I don't have a better idea than that either, but I sure feel that they don't belong in index.h. Is it worth inventing a whole new header for these? If we stick 'em in itemptr.h, they'll be getting compiled by a whole lot of files :-( As for the general usability argument, I'm not sure --- as we start to look at alternate AMs, we might have more use for them. When I first saw the functions, I thought maybe they were part of sort acceleration for TIDs; evidently they're not (yet), but that seems like another possible use-case. regards, tom lane