On Fri, Apr 26, 2019 at 5:05 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Yeah, I'd be fine with that, although the disconnect between the type > name and the comment terminology might confuse some people.
Maybe, but the fact that the ItemIdData struct consists of bit fields that are all named "lp_*" offers a hint. Plus you have the LP_* constants that get stored in ItemIdData.lp_flags. I wouldn't call the struct ItemIdData if I was in a green field situation, but it doesn't seem too bad under the present circumstances. I'd rather not change the struct's name, because that would probably cause problems without any real benefit. OTOH, calling two closely related but distinct things by the same name is atrocious. -- Peter Geoghegan
