On Tue, Apr 30, 2019 at 6:28 PM Peter Geoghegan <p...@bowt.ie> wrote: > Attached is a much more polished version of the same patch. I tried to > make clear how the "page full" test (the test that has been fixed to > take heap TID space for high key into account) is related to other > close-by code, such as the tuple space limit budget within > _bt_check_third_page(), and the code that sets up an actual call to > _bt_truncate().
Pushed, though final version does the test a little differently. It adds the required heap TID space to itupsz, rather than subtracting it from pgspc. This is actually representative of the underlying logic, and avoids unsigned underflow. -- Peter Geoghegan