On Fri, May 17, 2019 at 1:51 PM Andres Freund <and...@anarazel.de> wrote:
>
> > /*
> ------------------------------------------------------------------------
> > * Planner related callbacks for the heap AM
> > @@ -2558,6 +2615,8 @@ static const TableAmRoutine heapam_methods = {
> >
> > .relation_estimate_size = heapam_estimate_rel_size,
> >
> > + .needs_toast_table = heapam_needs_toast_table,
> > +
>
> I'd rather see this have a relation_ prefix.
>
+1 to overall patch with that comment incorporated. This seems simple
enough to incorporate for v12. Though stating that blind-folded with what
else is remaining to be must done for v12.
