On Thu, Jun 6, 2019 at 10:21 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Thu, Jun 06, 2019 at 05:16:30PM +0900, Masahiko Sawada wrote: > > So I'd like to propose a small fix for that; move the comment to the > > right place and add another comment. Please find an attached small > > patch. > > No objections to that. Perhaps we should also mention that this does > not protect from someone starting the cluster concurrently and that > the reason why we require a clean shutdown is that we may get checksum > failures because of torn pages?
Agreed. Please find an attached patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
fix_pg_checksums_v2.patch
Description: Binary data
