On 2019-06-13 14:30, Masahiko Sawada wrote: > Why do we need to change pg_fatal() to fprintf() & exit()? It seems to > me that we can still use pg_fatal() here since we write the message to > stderr.
It just makes the output more consistent with other tools, e.g., old: pg_upgrade: unrecognized option `--foo' Try "pg_upgrade --help" for more information. Failure, exiting new: pg_upgrade: unrecognized option `--foo' Try "pg_upgrade --help" for more information. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services