Hi, On 2019-06-17 21:46:02 -0400, Steve Singer wrote: > On 6/15/19 10:18 PM, Tom Lane wrote: > > Steve Singer <st...@ssinger.info> writes: > > > I encountered the following segfault when running against a PG 12 beta1 > > > during a analyze against a table. > > Nobody else has reported this, so you're going to have to work on > > producing a self-contained test case, or else debugging it yourself. > > > > regards, tom lane > > > > > > > The attached patch fixes the issue.
Thanks for the bug report, diagnosis and patch. Pushed. I included a small testcase for ANALYZE running in a transaction that also modified a few rows, after going back and forth on it for a while. Seems unlikely that we'll reintroduce this specific bug, but it seems good to have test coverage a least some of the HEAPTUPLE_DELETE_IN_PROGRESS path. We currently have none... I think the testcase would catch the issue at hand on most machines, by mixing live/dead/deleted-by-current-transaction rows. Greetings, Andres Freund