On Thu, Jun 27, 2019 at 10:09 PM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > On 2019-Jun-27, Tom Lane wrote: > > > Dunno, I just can't get excited about exposing REVMAP_PAGE_MAXITEMS. > > Especially not since we seem to agree on the long-term solution here, > > and what you're suggesting to Julien doesn't particularly fit into > > that long-term solution. > > Well, it was brin_page.h, which is supposed to be internal to BRIN > itself. But since we admit that in its current state selfuncs.c is not > salvageable as a module and we'll redo the whole thing in the short > term, I withdraw my comment.
Thanks. I'll also work soon on a patch to move the [am]costestimate functions in the am-specific files.