>>>>> "Richard" == Richard Guo <ri...@pivotal.io> writes:
Richard> Hi all, Richard> During the reorder of grouping sets into correct prefix order, Richard> if only one aggregation pass is needed, we follow the order of Richard> the ORDER BY clause to the extent possible, to minimize the Richard> chance that we add unnecessary sorts. This is implemented in Richard> preprocess_grouping_sets --> reorder_grouping_sets. Richard> However, current codes fail to do that. You're correct, thanks for the report. Your fix works, but I prefer to refactor the conditional logic slightly instead, removing the outer if{}. So I didn't use your exact patch in the fix I just committed. -- Andrew (irc:RhodiumToad)