Tomas Vondra <tomas.von...@2ndquadrant.com> writes: > There seems to be a consensus that this this not a pg_basebackup issue > (i.e. duplicate values don't make the file invalid), and it should be > handled in ALTER SYSTEM.
Yeah. I doubt pg_basebackup is the only actor that can create such situations. > The proposal seems to be to run through the .auto.conf file, remove any > duplicates, and append the new entry at the end. That seems reasonable. +1 > There was a discussion whether to print warnings about the duplicates. I > personally see not much point in doing that - if we consider duplicates > to be expected, and if ALTER SYSTEM has the license to rework the config > file any way it wants, why warn about it? Personally I agree that warnings are unnecessary. > The main issue however is that no code was written yet. Seems like it ought to be relatively simple ... but I didn't look. regards, tom lane