On Sun, Aug 4, 2019 at 12:13 PM Michael Paquier <mich...@paquier.xyz> wrote:
> On Sat, Aug 03, 2019 at 11:57:01PM -0400, Alvaro Herrera wrote: > > Can we please change the macro definition so that have_error is one of > > the arguments? Having the variable be used inside the macro definition > > but not appear literally in the call is quite confusing. > Can't agree more. This is where I also got confused initially and thought the flag is unused. Good idea. This needs some changes only in float.c. Please find attached patch with the changes to RETURN_ERROR and it's references in float.c Regards, Jeevan Ladhe
0001-Make-have_error-initialization-more-defensive-v3.patch
Description: Binary data
