Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > Then there's the <limits.h> removal, which is in tuplesort.c because of > INT_MAX as added by commit d26559dbf356 and still present ...
One has to be especially wary of removing system-header inclusions; the fact that they don't seem to be needed on your own machine doesn't prove they aren't needed elsewhere. > ... I suggest this patch should be rejected. Yeah. If we do anything along this line it should be based on pgrminclude results, and even then I think it'd require manual review, especially for changes in header files. The big picture here is that removing #includes is seldom worth the effort it takes :-( regards, tom lane