On Fri, Aug 23, 2019 at 9:08 PM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > On 2019-Aug-23, Asim R P wrote: > > > As part of the fault injector patch set [1], I added a new "blocking" > > keyword to isolation grammar so that a step can be declared as blocking. > > See patch 0002-Add-syntax-to-declare-a-step-that-is-expected-to-block. > > One point to that implementation is that in that design a step is > globally declared to be blocking, but in reality that's the wrong way to > see things: a step might block in some permutations and not others. So > I think we should do as Michael suggested: it's the permutation that has > to have a way to mark a given step as blocking, not the step itself.
Thank you for the feedback. I've changed patch 0002 accordingly, please take another look: https://www.postgresql.org/message-id/CANXE4TdvSi7Yia_5sV82%2BMHf0WcUSN9u6_X8VEUBv-YStphd%3DQ%40mail.gmail.com Asim
