On Tue, Oct 1, 2019 at 08:40:26AM -0400, Andrew Dunstan wrote: > > On 10/1/19 6:12 AM, Amit Kapila wrote: > > On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter <pet...@fast.au.fujitsu.com> > > wrote: > >> Dear Hackers, > >> > >> I have identified some OSS code which maybe can make use of C99 designated > >> initialisers for nulls/values arrays. > >> > >> ~ > >> > >> Background: > >> There are lots of tuple operations where arrays of values and flags are > >> being passed. > >> Typically these arrays are being previously initialised 0/false by memset. > >> By modifying code to use C99 designated initialiser syntax [1], most of > >> these memsets can become redundant. > >> Actually, this mechanism is already being used in some of the existing OSS > >> code. This patch/proposal just propagates the same idea to all other > >> similar places I could find. > >> > >> ~ > >> > >> Result: > >> Less code. Removes ~200 unnecessary memsets. > >> More consistent initialisation. > >> > > +1. This seems like an improvement. I can review and take this > > forward unless there are objections from others. > > > > > > +1.
I like it! -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
