On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote: > > I have attached the updated patch with the fixes. > > The changes in rangetypes_gist.c are not correct, the usual pattern to > add an "s" after the structure name is quite common when referring to > multiple elements. We could perhaps use "put-your-struct entries" > instead, but I have seen the pattern of HEAD quite a lot as well (see > also for example mcv.c with SortItem that is a file your patch > touches). > > A comment indentation was wrong in detoast.c, not the fault of this > patch but I have fixed it at the same time. > Thanks for pushing the changes Michael.
Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
