Yuya Watari <watari.y...@gmail.com> writes: > The added macro FLOAT8_FITS_IN_INT32() does not check NaN explicitly, > but it sufficiently handles the case.
Really? I don't think anything is guaranteed about how a NaN will compare when using C's non-NaN-aware comparison operators. My thought about this was to annotate the macros with a reminder to also check for NaN if there's any possibility that the value is NaN. regards, tom lane