On Mon, Oct 28, 2019 at 03:42:02AM +0000, Smith, Peter wrote: > From: Kyotaro Horiguchi <horikyota....@gmail.com> Sent: Monday, 28 October > 2019 1:26 PM >> It is missing the __cplusplus case? > > My use cases for the macro are only in C code, so that's all I was interested > in at this time. > If somebody else wants to extend the patch for C++ also (and test it) they > can do.
It seems to me that there is a good point to be consistent with the treatment of StaticAssertStmt and StaticAssertExpr in c.h, which have fallback implementations in *all* the configurations supported. @@ -858,7 +863,6 @@ extern void ExceptionalCondition(const char *conditionName, #endif #endif /* C++ */ - /* A nit: noise diffs. (No need to send a new version just for that.) -- Michael
signature.asc
Description: PGP signature
