On Thu, Nov 21, 2019 at 8:32 PM Juan José Santamaría Flecha <juanjo.santama...@gmail.com> wrote: > > On Thu, Nov 21, 2019 at 5:02 AM Amit Kapila <amit.kapil...@gmail.com> wrote: >> >> On Wed, Nov 20, 2019 at 5:41 PM Juan José Santamaría Flecha >> <juanjo.santama...@gmail.com> wrote: >> > >> > On Wed, Nov 20, 2019 at 9:48 AM Amit Khandekar <amitdkhan...@gmail.com> >> > wrote: >> >> >> >> On Wed, 20 Nov 2019 at 13:10, Amit Kapila <amit.kapil...@gmail.com> wrote: >> >> > See comment in pgunlink() "We need to loop because even though >> >> > PostgreSQL uses flags that allow unlink while the file is open, other >> >> > applications might have the file >> >> > open without those flags.". Can you once see if there is any flag >> >> > that you have missed to pass to allow this? >> >> >> >> > If there is nothing we >> >> > can do about it, then we might need to use some different API or maybe >> >> > define a new API that can handle this. >> >> >> >> There were objections against modifying the vfd api only for this >> >> replication-related use-case. Having a new API will require all the >> >> changes required to enable the virtual FDs feature that we need from >> >> vfd. If nothing works out from the FILE_SHARE_DELETE thing, I am >> >> thinking, we can use VFD, plus we can keep track of per-subtransaction >> >> vfd handles, and do something similar to AtEOSubXact_Files(). >> >> >> > >> > The comment about "other applications might have the file open without >> > those flags." is surely due to systems working with an antivirus touching >> > Postgres files. >> > >> > I was not able to reproduce the Permission denied error with current HEAD, >> > >> >> I am not sure what exactly you tried. Can you share the steps and >> your environment details? >> > > Sure, I was trying to reproduce the Permission denied error after the > ERROR_HANDLE_EOF fix. >
Have you tried before that fix , if not, can you once try by temporarily reverting that fix in your environment and share the output of each step? After you get the error due to EOF, check that you have .spill files in pg_replslot/<slot_name>/ and then again try to get changes by pg_logical_slot_get_changes(). If you want, you can use the test provided in Amit Khandekar's patch. > > [1] Win10 (1903) MSVC 19.22.27905 > I have tested this on Windows7. I am not sure if it is due to a different version of windows, but I think we can't rule out that possibility. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
