On Tue, 3 Dec 2019 at 07:09, Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Dec 02, 2019 at 10:14:58PM +0100, Masahiko Sawada wrote: > > Agreed. I've attached the updated version patch. Please review it. > > Thanks, applied on HEAD after a few edits. gettext() does not set > errno, so the new style of issue_xlog_fsync() is actually fine.
Thanks! > Please note that there was one mistake in the patch: you forgot to > assign back errno in assign_xlog_sync_method() after generating the > file name. My bad. Thank you for fixing it. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
