On Tue, 21 Jan 2020 at 18:16, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Jan 21, 2020 at 12:51 PM Masahiko Sawada > <masahiko.saw...@2ndquadrant.com> wrote: > > > > On Tue, 21 Jan 2020 at 16:13, Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > SizeOfLVDeadTuplesHeader is not defined by patch. Do you think it > > > makes sense to add a comment here about the calculation? > > > > Oops, it should be SizeOfLVDeadTuples. Attached updated version. > > > > I defined two macros: SizeOfLVDeadTuples is the size of LVDeadTuples > > struct and SizeOfDeadTuples is the size including LVDeadTuples struct > > and dead tuples. > > > > I have reproduced the issue by defining MaxAllocSize as 10240000 and > then during debugging, skipped the check related to LAZY_ALLOC_TUPLES. > After patch, it fixes the problem for me. I have slightly modified > your patch to define the macros on the lines of existing macros > TXID_SNAPSHOT_SIZE and TXID_SNAPSHOT_MAX_NXIP. What do you think > about it?
Thank you for updating the patch. Yeah MAXDEADTUPLES is better than what I did in the previous version patch. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services