At Thu, 23 Jan 2020 21:28:54 +0900 (JST), Kyotaro Horiguchi
<horikyota....@gmail.com> wrote in
> > In the same function, I think that setting restBytes to -1 when
> > "useless" is bad style. I would just leave that variable alone when the
> > returned status is not one that receives the number of bytes. So the
> > caller is only entitled to read the value if the returned enum value is
> > such-and-such ("keeping" and "streaming" I think).
>
> That is the only condition. If max_slot_wal_keep_size = -1, The value
> is useless for the two states. I added that explanation to the
> comment of Get(Lsn)Walavailability().
The reply is bogus since restBytes is no longer a parameter of
GetWalAvailability following the next comment.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
