On Thu, 16 Jan 2020 at 09:36, Michael Paquier <mich...@paquier.xyz> wrote: > > On Fri, Jan 10, 2020 at 08:07:48PM +0900, Michael Paquier wrote: > > Thinking more about it, this has a race condition if a temporary > > schema is removed after collecting the OIDs in the drop phase. So the > > updated attached is actually much more conservative and does not need > > an update of the log message, without giving up on the improvements > > done in v11~. In 9.4~10, the code of the second phase relies on > > GetTempNamespaceBackendId() which causes an orphaned relation to not > > be dropped in the event of a missing namespace. I'll just leave that > > alone for a couple of days now.. > > And back on that one, I still like better the solution as of the > attached which skips any relations with their namespace gone missing > as 246a6c87's intention was only to allow orphaned temp relations to > be dropped by autovacuum when a backend slot is connected, but not > using yet its own temp namespace. > > If we want the drop of temp relations to work properly, more thoughts > are needed regarding the storage part, and I am not actually sure that > it is autovacuum's job to handle that better. > > Any thoughts? Hi,
Patch looks good to me and it is fixing the assert failure. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
