Hello,
On 3/12/2020 4:44 AM, Tom Lane wrote:
Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <dev...@gunduz.org> writes:
I'm getting build error while building latest snapshot. Any idea why? Please
note that I'm adding this patch to the tarball:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/postgresql-13/master/postgresql-13-var-run-socket.patch;h=a0292a80ae219b4c8dc1c2e686a3521f02b4330d;hb=HEAD
(Hey, I recognize that patch ...)
In file included from ../../../../src/include/c.h:55,
from ../../../../src/include/postgres.h:46,
from guc.c:17:
../../../../src/include/pg_config_manual.h:200:31: error: called object is not
a function or function pointer
#define DEFAULT_PGSOCKET_DIR "/var/run/postgresql"
^~~~~~~~~~~~~~~~~~~~~
guc.c:4064:3: note: in expansion of macro 'DEFAULT_PGSOCKET_DIR'
DEFAULT_PGSOCKET_DIR ", /tmp"
^~~~~~~~~~~~~~~~~~~~
make[4]: *** [<builtin>: guc.o] Error 1
That is just weird. Could it be a compiler bug? I assume you're
using some bleeding-edge gcc version, and it's really hard to see
another reason why this would fail, especially with a nonsensical
error like that.
I'm not familiar with the patch itself. But I think there is just a lack
of the comma here, after ", /tmp" :-)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -4061,7 +4061,7 @@ static struct config_string ConfigureNamesString[] =
},
&Unix_socket_directories,
#ifdef HAVE_UNIX_SOCKETS
- DEFAULT_PGSOCKET_DIR,
+ DEFAULT_PGSOCKET_DIR ", /tmp"
#else
"",
#endif
So, it should be:
> #ifdef HAVE_UNIX_SOCKETS
- DEFAULT_PGSOCKET_DIR,
+ DEFAULT_PGSOCKET_DIR ", /tmp",
#else
--
Artur
