On 2020-Mar-14, Paul A Jungwirth wrote: > On Fri, Mar 13, 2020 at 2:39 PM Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > > Here's the rebased version. > > > > I just realized I didn't include the API change I proposed in > > https://postgr.es/m/20200306200343.GA625@alvherre.pgsql ... > > Thanks for your help with this Alvaro! > > I was just adding your changes to my own branch and I noticed your > v12-0001 has different parameter names here: > > static MultirangeIOData * > -get_multirange_io_data(FunctionCallInfo fcinfo, Oid mltrngtypid, > IOFuncSelector func) > +get_multirange_io_data(FunctionCallInfo fcinfo, Oid rngtypid, > IOFuncSelector func)
> I'm pretty sure mltrngtypid is the correct name here. Right? Let me > know if I'm missing something. :-) Heh. The intention here was to abbreviate to "typid", but if you want to keep the longer name, it's OK too. I don't think that name is particularly critical, since it should be obvious that it must be a multirange type. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
