Em seg., 30 de mar. de 2020 às 05:16, Michael Paquier <mich...@paquier.xyz> escreveu:
> On Sat, Mar 28, 2020 at 07:48:22AM -0300, Ranier Vilela wrote: > > I completely disagree. My tools have proven their worth, including > finding > > serious errors in the code, which fortunately have been fixed by other > > committers. > > FWIW, I think that the rule to always take Coverity's reports with a > pinch of salt applies for any report. > I have certainly taken this advice seriously, since I have received all kinds of say, "words of discouragement". I understand perfectly that the list is very busy and perhaps the patience with mistakes is very little, but these attitudes do not help new people to work here. I don't get paid to work with PostgreSQL, so consideration and recognition are the only rewards for now. > > > When issuing this alert, the tool does not value judgment regarding > > performance or optimization, but it does an excellent job of finding > > similar patterns in adjacent lines, and the only thing it asked for was > to > > be asked if this was really the case. original author's intention. > > The code context matters a lot, but here let's leave this code alone. > There is nothing wrong with it. > That is the question. Looking only at the code, there is no way to know immediately, that there is nothing wrong. Not even a comment warning. That's what the tool asked for, ask if there's really nothing wrong. regards, Ranier Vilela
