On Tue, Mar 31, 2020 at 01:56:07PM +0300, Alexey Kondratov wrote: > I am fine with allowing REINDEX (CONCURRENTLY), but then we will have to > support both syntaxes as we already do for VACUUM. Anyway, if we agree to > add parenthesized options to REINDEX/CLUSTER, then it should be done as a > separated patch before the current patch set.
Last year for the patch for REINDEX CONCURRENTLY, we had the argument of supporting only the parenthesized grammar or not, and the choice has been made to use what we have now, as you mentioned upthread. I would honestly prefer that for now on we only add the parenthesized version of an option if something new is added to such utility commands (vacuum, analyze, reindex, etc.) as that's much more extensible from the point of view of the parser. And this, even if you need to rework things a bit more things around reindex_option_elem for the tablespace option proposed here. -- Michael
signature.asc
Description: PGP signature