On Thu, Apr 02, 2020 at 04:24:03PM +0900, Michael Paquier wrote: > On Thu, Apr 02, 2020 at 01:52:09AM -0500, Justin Pryzby wrote: >> Sounds right. Or else get_index_isclustered() could be redefined to take a >> boolean "do_elog" flag, and if syscache fails and that's false, then return >> false instead of ERROR. > > Not sure if that's completely right to do either. For one, it is not > consistent with the surroundings as of lsyscache.c.
Actually, we do have some missing_ok flags lying around already in lsyscache.c, so it would be much more consistent to use that name that instead of the do_elog you are suggesting. Could you update the patch to reflect that? -- Michael
signature.asc
Description: PGP signature
